Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1892)

Unified Diff: chrome/browser/profiles/profile_io_data.cc

Issue 317613004: Remove usage of singleton software_slot_ in nss on ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_io_data.cc
diff --git a/chrome/browser/profiles/profile_io_data.cc b/chrome/browser/profiles/profile_io_data.cc
index 09993085d14987895e8ce822c57362f2bf5af7f4..c87ccbabceb18960b2e4eb6829806244cf0f5cd3 100644
--- a/chrome/browser/profiles/profile_io_data.cc
+++ b/chrome/browser/profiles/profile_io_data.cc
@@ -288,15 +288,12 @@ void StartTPMSlotInitializationOnIOThread(const std::string& username,
void StartNSSInitOnIOThread(const std::string& username,
const std::string& username_hash,
- const base::FilePath& path,
- bool is_primary_user) {
+ const base::FilePath& path) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
DVLOG(1) << "Starting NSS init for " << username
- << " hash:" << username_hash
- << " is_primary_user:" << is_primary_user;
-
+ << " hash:" << username_hash;
if (!crypto::InitializeNSSForChromeOSUser(
- username, username_hash, is_primary_user, path)) {
+ username, username_hash, path, false /* not provisional*/)) {
// If the user already exists in nss_util's map, it is already initialized
// or in the process of being initialized. In either case, there's no need
// to do anything.
@@ -360,20 +357,22 @@ void ProfileIOData::InitializeOnUIThread(Profile* profile) {
if (user_manager) {
chromeos::User* user =
chromeos::ProfileHelper::Get()->GetUserByProfile(profile);
- if (user) {
+ // No need to initialize NSS for users with empty username hash:
+ // Getters for a user's NSS slots always return NULL slot if the user's
+ // username hash is empty, even when the NSS is not initialized for the
+ // user.
+ if (user && !user->username_hash().empty()) {
params->username_hash = user->username_hash();
- bool is_primary_user = (user_manager->GetPrimaryUser() == user);
BrowserThread::PostTask(BrowserThread::IO,
FROM_HERE,
base::Bind(&StartNSSInitOnIOThread,
user->email(),
user->username_hash(),
- profile->GetPath(),
- is_primary_user));
+ profile->GetPath()));
}
}
if (params->username_hash.empty())
- LOG(WARNING) << "no username_hash";
+ LOG(WARNING) << "No username_hash; skipped NSS initialization.";
#endif
params->profile = profile;

Powered by Google App Engine
This is Rietveld 408576698