Remove usage of singleton software_slot_ in nss on ChromeOS

chrome/browser/chromeos/login/auth/parallel_authenticator.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/auth/parallel_authenticator.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
@@ skipping 490 matching lines @@
     user_can_login_ = true;
     owner_is_verified_ = true;
     return true;
   }
 
   const std::string& user_id = current_state_->user_context.GetUserID();
   OwnerSettingsServiceFactory::GetInstance()->SetUsername(user_id);
 
   // This should trigger certificate loading, which is needed in order to
   // correctly determine if the current user is the owner.
   if (LoginState::IsInitialized()) {

[pneubeck (no reviews), 2014/07/01 14:37:17]

When you added this, you wrote that SafeMode depends on the CertLoader:
https://chromiumcodereview.appspot.com/23684033

Even in the old version of CertLoader when it included the TPM initialization,
why is this dependency? SafeMode only requires the private key from the software
token and neither certs nor the TPM being initialized, IIUC. The purpose of the
certificate loading in CertLoader is also solely to have a list of certs
available for the UI thread.

If the dependency is required, how was the old code supposed to be synchronized
with the cert loading? the loading is asynchronous and I don't see any waiting
for events.

[tbarzic, 2014/07/01 16:33:07]

It depended on CertLoader because CertLoader was actually where software token
used to be loaded (OpenPersistentNSSDB in TPMTokenLoader used to be part of
CertLoader class). Though, I admit that that cl description could have been more
precise.

[pneubeck (no reviews), 2014/07/09 16:08:11]

Since you're removing OpenPersistentNSSDB from TPMTokenLoader and instead
initializing the NSSDB in IsOwnerForSafeModeAsync,
isn't this comment incorrect now?

[tbarzic, 2014/07/09 20:45:33]

Changed the comment, though, it may make sense to remove this logged in state
after this lands.

     LoginState::Get()->SetLoggedInState(LoginState::LOGGED_IN_SAFE_MODE,
                                         LoginState::LOGGED_IN_USER_NONE);
   }
 
-  OwnerSettingsService::IsPrivateKeyExistAsync(
+  OwnerSettingsService::IsOwnerForSafeModeAsync(
+      user_id,
+      current_state_->user_context.GetUserIDHash(),
       base::Bind(&ParallelAuthenticator::OnOwnershipChecked, this));
   return false;
 }
 
 void ParallelAuthenticator::OnOwnershipChecked(bool is_owner) {
   // Now we can check if this user is the owner.
   user_can_login_ = is_owner;
   owner_is_verified_ = true;
   Resolve();
 }
@@ skipping 286 matching lines @@
   Resolve();
 }
 
 void ParallelAuthenticator::SetOwnerState(bool owner_check_finished,
                                           bool check_result) {
   owner_is_verified_ = owner_check_finished;
   user_can_login_ = check_result;
 }
 
 }  // namespace chromeos