Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 317613002: Switch ChromeVox translations to the non-third_party ones. (Closed)

Created:
6 years, 6 months ago by Peter Lundblad
Modified:
6 years, 6 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Visibility:
Public.

Description

Switch ChromeVox translations to the non-third_party ones. This aligns ChromeVox's supported languages with those of Chromium, adding at least one new language that was missed before. BUG=366197 R=dtseng@chromium.org Tested=Tried chromevox in US English, Swedish, Norwegian and German, including navigating, options page and plural handling of characters. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -51 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox.gyp View 1 chunk +1 line, -3 lines 0 comments Download
D chrome/third_party/chromevox/_locales/am/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/ar/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/bg/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/ca/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/cs/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/da/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/de/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/el/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/en/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/en_GB/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/es/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/es_419/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/et/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/fi/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/fr/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/he/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/hi/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/hr/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/hu/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/id/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/it/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/ja/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/ko/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/lt/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/lv/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/nl/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/pl/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/pt_BR/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/pt_PT/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/ro/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/ru/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/sk/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/sl/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/sr/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/sv/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/sw/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/th/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/tr/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/uk/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/vi/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/zh_CN/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/third_party/chromevox/_locales/zh_TW/messages.json View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/third_party/chromevox/chromevox.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Peter Lundblad
6 years, 6 months ago (2014-06-04 00:42:42 UTC) #1
dmazzoni
lgtm
6 years, 6 months ago (2014-06-04 07:08:00 UTC) #2
David Tseng
lgtm
6 years, 6 months ago (2014-06-04 14:44:19 UTC) #3
Peter Lundblad
The CQ bit was checked by plundblad@chromium.org
6 years, 6 months ago (2014-06-04 14:51:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/317613002/1
6 years, 6 months ago (2014-06-04 14:53:18 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 18:14:55 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 18:20:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10421)
6 years, 6 months ago (2014-06-04 18:20:05 UTC) #8
Peter Lundblad
The CQ bit was checked by plundblad@chromium.org
6 years, 6 months ago (2014-06-04 18:23:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/317613002/1
6 years, 6 months ago (2014-06-04 18:26:15 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 18:34:54 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 19:07:12 UTC) #12
Message was sent while issue was closed.
Change committed as 274882

Powered by Google App Engine
This is Rietveld 408576698