Issue 3176024: Convert wstrings in bookmarks, part 4.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3176024: Convert wstrings in bookmarks, part 4. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by viettrungluu

Modified:
3 years, 11 months ago

Reviewers:
Lei Zhang, Nico, Miranda Callahan

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Visibility:
Public.

Convert wstrings in bookmarks, part 4. - convert GetURLAndTitleToBookmark() and GetURLsForOpenTabs() - convert BookmarkEditor::EditDetails BUG=23581 TEST=builds and passes tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56821

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -14 lines)			Patch
M	chrome/browser/bookmarks/bookmark_editor.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/browser.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/bookmark_editor_view_unittest.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Trybot results: linux_view linux win mac

Total messages: 2 (0 generated)

LG