Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 3176008: Set the title for wait-for-debugger dialog to be "Chromium". We were fetching... (Closed)

Created:
10 years, 4 months ago by alokp
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Set the title for wait-for-debugger dialog to be "Chromium". We were fetching the product name from resource bundle, which is not available for child processes that do not need it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56416

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M chrome/common/child_process.cc View 1 2 chunks +25 lines, -22 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
alokp
I was trying to make the gpu process wait for the debugger with --gpu-startup-dialog flag. ...
10 years, 4 months ago (2010-08-12 21:32:34 UTC) #1
Andrew T Wilson (Slow)
LGTM, with one nit. Can we add this: #if defined(GOOGLE_CHROME_BUILD) std::wstring title = L"Google Chrome"; ...
10 years, 4 months ago (2010-08-12 22:06:22 UTC) #2
alokp
10 years, 4 months ago (2010-08-12 22:19:03 UTC) #3
DONE.

Also formatted the function. For some reason it was indented with 4 spaces.

Powered by Google App Engine
This is Rietveld 408576698