dm/DMPDFTask.cpp - Issue 317533003: Disable PDF in dm for tonight. It's crashy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DMPDFTask.cpp

Issue 317533003: Disable PDF in dm for tonight. It's crashy. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DMPDFTask.cpp

diff --git a/dm/DMPDFTask.cpp b/dm/DMPDFTask.cpp

index 270f4b4fef8bbfd1863e397acfc93a3f77efec32..e50e9ecb70fcaa194e7e20668b29bbe1615a5855 100644

--- a/dm/DMPDFTask.cpp

+++ b/dm/DMPDFTask.cpp

@@ -13,7 +13,11 @@

#include "SkCommandLineFlags.h"

#include "SkDocument.h"

-DEFINE_bool(pdf, true, "PDF backend master switch.");

+// The PDF backend is not threadsafe. If you run dm with --pdf repeatedly, you

+// will quickly find yourself crashed. (while catchsegv out/Release/dm;; end).

+//

+// TODO(mtklein): re-enable by default, maybe moving to its own single thread.

+DEFINE_bool(pdf, false, "PDF backend master switch.");

namespace DM {

« no previous file with comments | « no previous file | no next file » | no next file with comments »