Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 317503002: AsanCoverage: make the filenames of zygote/gpu coverage files more unique. (Closed)

Created:
6 years, 6 months ago by earthdok
Modified:
6 years, 6 months ago
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

AsanCoverage: make the filenames of zygote/gpu coverage files more unique. BUG=336212 R=jln@chromium.org TBR=kbr@chromium.org NOTRY=true TEST=ASan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274644

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M content/gpu/gpu_main.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
earthdok
ptal
6 years, 6 months ago (2014-06-03 21:27:12 UTC) #1
jln (very slow on Chromium)
lgtm with nit. Let's not use stringstream. ASAN will add .sancov to the name automatically ...
6 years, 6 months ago (2014-06-03 21:43:40 UTC) #2
earthdok
https://codereview.chromium.org/317503002/diff/1/content/gpu/gpu_main.cc File content/gpu/gpu_main.cc (right): https://codereview.chromium.org/317503002/diff/1/content/gpu/gpu_main.cc#newcode455 content/gpu/gpu_main.cc:455: std::string sancov_file_name = ss.str(); On 2014/06/03 21:43:40, jln wrote: ...
6 years, 6 months ago (2014-06-03 21:49:26 UTC) #3
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 6 months ago (2014-06-03 21:52:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/317503002/20001
6 years, 6 months ago (2014-06-03 21:53:55 UTC) #5
Ken Russell (switch to Gerrit)
lgtm
6 years, 6 months ago (2014-06-03 21:55:56 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 21:57:40 UTC) #7
Message was sent while issue was closed.
Change committed as 274644

Powered by Google App Engine
This is Rietveld 408576698