Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 3175001: Build just chrome to shorten the Coverity build and analysis... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by wtc
Modified:
4 years ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Build just chrome to shorten the Coverity build and analysis time. Remove a stale TODO comment. R=bevc,jimhebert BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55637

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix the directory of chrome.xcodeproj. #

Patch Set 3 : Remove a stale TODO comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M tools/coverity/coverity.py View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 5 (0 generated)
wtc
Bev, Jim: Here are the command-line changes to build just chrome. Let's coordinate and make ...
4 years, 9 months ago (2010-08-10 21:36:07 UTC) #1
Mark Mentovai - out til August
http://codereview.chromium.org/3175001/diff/1/2 File tools/coverity/coverity.py (right): http://codereview.chromium.org/3175001/diff/1/2#newcode184 tools/coverity/coverity.py:184: os.chdir('src/build') This directory… http://codereview.chromium.org/3175001/diff/1/2#newcode186 tools/coverity/coverity.py:186: cmd = ('%s/cov-build --dir ...
4 years, 9 months ago (2010-08-10 21:43:53 UTC) #2
jimhebert
FWIW I don't know enough about the build to sort out between your change and ...
4 years, 9 months ago (2010-08-10 23:10:31 UTC) #3
bevc
lgtm
4 years, 9 months ago (2010-08-10 23:51:34 UTC) #4
Mark Mentovai - out til August
4 years, 9 months ago (2010-08-11 15:09:50 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be