Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: tools/coverity/coverity.py

Issue 3175001: Build just chrome to shorten the Coverity build and analysis... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Remove a stale TODO comment. Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/coverity/coverity.py
===================================================================
--- tools/coverity/coverity.py (revision 55580)
+++ tools/coverity/coverity.py (working copy)
@@ -88,8 +88,6 @@
"""Runs the command if dry_run is false, otherwise just prints the command."""
if echo_cmd:
print cmd
- # TODO(wtc): Check the return value of subprocess.call, which is the return
- # value of the command.
if not dry_run:
return subprocess.call(cmd, shell=shell)
else:
@@ -171,19 +169,20 @@
use_shell_during_make = True
os.chdir('src')
_RunCommand('pwd', options.dry_run, shell=True)
- cmd = '%s/cov-build --dir %s make BUILDTYPE=%s' % (
+ cmd = '%s/cov-build --dir %s make BUILDTYPE=%s chrome' % (
options.coverity_bin_dir, options.coverity_intermediate_dir,
options.target)
elif sys.platform == 'win32':
- cmd = '%s\\cov-build.exe --dir %s devenv.com %s\\%s /build %s' % (
+ cmd = ('%s\\cov-build.exe --dir %s devenv.com %s\\%s /build %s '
+ '/project chrome.vcproj') % (
options.coverity_bin_dir, options.coverity_intermediate_dir,
options.source_dir, options.solution_file, options.target)
elif sys.platform == 'darwin':
use_shell_during_make = True
- os.chdir('src/build')
+ os.chdir('src/chrome')
_RunCommand('pwd', options.dry_run, shell=True)
- cmd = ('%s/cov-build --dir %s xcodebuild -project all.xcodeproj '
- '-configuration %s -target All') % (
+ cmd = ('%s/cov-build --dir %s xcodebuild -project chrome.xcodeproj '
+ '-configuration %s -target chrome') % (
options.coverity_bin_dir, options.coverity_intermediate_dir,
options.target)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698