Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: webkit/glue/cpp_bound_class.h

Issue 3175: Pass the invoked JavaScript method name as an argument to the fallback callback (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/glue/cpp_bound_class.h
===================================================================
--- webkit/glue/cpp_bound_class.h (revision 2868)
+++ webkit/glue/cpp_bound_class.h (working copy)
@@ -74,8 +74,8 @@
// Bind the Javascript property called |name| to a CppVariant |prop|.
void BindProperty(std::string name, CppVariant* prop);
- // Set the fallback callback, which is called when when a callback is
- // invoked that isn't bound.
+ // Set the fallback callback, which is called when a callback is invoked
+ // that isn't bound.
// If it is NULL (its default value), a JavaScript exception is thrown in
// that case (as normally expected). If non NULL, the fallback method is
// invoked and the script continues its execution.
@@ -84,6 +84,8 @@
// as it may cause unexpected behaviors (a JavaScript object with a
// fallback always returns true when checked for a method's
// existence).
+ // The name of the nonexistent JavaScript method will be passed as the
+ // first argument to the fallback method.
void BindFallbackCallback(Callback* fallback_callback) {
fallback_callback_.reset(fallback_callback);
}
« no previous file with comments | « AUTHORS ('k') | webkit/glue/cpp_bound_class.cc » ('j') | webkit/glue/cpp_bound_class.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698