Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: Source/modules/geolocation/testing/InternalsGeolocation.cpp

Issue 317493002: Change FrameTree to return Frames instead of LocalFrames. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: dcheng's comment addressed Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/testing/Internals.cpp ('k') | Source/web/SpellCheckerClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/geolocation/testing/InternalsGeolocation.cpp
diff --git a/Source/modules/geolocation/testing/InternalsGeolocation.cpp b/Source/modules/geolocation/testing/InternalsGeolocation.cpp
index 06a1e6a07d8161344dda08c09758b0ca5045844f..a349b47576bc2c9dcd5cf5a0e12d8e612c60052e 100644
--- a/Source/modules/geolocation/testing/InternalsGeolocation.cpp
+++ b/Source/modules/geolocation/testing/InternalsGeolocation.cpp
@@ -47,8 +47,10 @@ void InternalsGeolocation::setGeolocationClientMock(Internals&, Document* docume
ASSERT(document && document->frame());
GeolocationClientMock* client = new GeolocationClientMock();
- for (LocalFrame* childFrame = document->page()->mainFrame(); childFrame; childFrame = childFrame->tree().traverseNext())
- GeolocationController::from(childFrame)->setClientForTest(client);
+ for (Frame* childFrame = document->page()->mainFrame(); childFrame; childFrame = childFrame->tree().traverseNext()) {
+ if (childFrame->isLocalFrame())
+ GeolocationController::from(toLocalFrame(childFrame))->setClientForTest(client);
+ }
}
void InternalsGeolocation::setGeolocationPosition(Internals&, Document* document, double latitude, double longitude, double accuracy)
« no previous file with comments | « Source/core/testing/Internals.cpp ('k') | Source/web/SpellCheckerClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698