Source/core/page/CreateWindow.cpp - Issue 317493002: Change FrameTree to return Frames instead of LocalFrames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/CreateWindow.cpp

Issue 317493002: Change FrameTree to return Frames instead of LocalFrames. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: dcheng's comment addressed Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/CreateWindow.cpp

diff --git a/Source/core/page/CreateWindow.cpp b/Source/core/page/CreateWindow.cpp

index bc8ac81b5d4da0cb56cd38f3a177b5110a5630c2..ab39dfa0a92d54b29fb2ce48ea61c0a75038cf15 100644

--- a/Source/core/page/CreateWindow.cpp

+++ b/Source/core/page/CreateWindow.cpp

@@ -68,7 +68,7 @@ static LocalFrame* createWindow(LocalFrame& openerFrame, LocalFrame& lookupFrame

created = false;

if (!openerFrame.tree().top()->isLocalFrame())

return 0;

- return openerFrame.tree().top();

+ return toLocalFrame(openerFrame.tree().top());

}

Page* oldPage = openerFrame.page();

« no previous file with comments | « Source/core/loader/appcache/ApplicationCacheHost.cpp ('k') | Source/core/page/FrameTree.h » ('j') | no next file with comments »