Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: Source/core/testing/Internals.cpp

Issue 317493002: Change FrameTree to return Frames instead of LocalFrames. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: dcheng's comment addressed Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1584 matching lines...) Expand 10 before | Expand all | Expand 10 after
1595 return document->frame()->spellChecker().selectionStartHasMarkerFor(Document Marker::Grammar, from, length); 1595 return document->frame()->spellChecker().selectionStartHasMarkerFor(Document Marker::Grammar, from, length);
1596 } 1596 }
1597 1597
1598 unsigned Internals::numberOfScrollableAreas(Document* document, ExceptionState&) 1598 unsigned Internals::numberOfScrollableAreas(Document* document, ExceptionState&)
1599 { 1599 {
1600 unsigned count = 0; 1600 unsigned count = 0;
1601 LocalFrame* frame = document->frame(); 1601 LocalFrame* frame = document->frame();
1602 if (frame->view()->scrollableAreas()) 1602 if (frame->view()->scrollableAreas())
1603 count += frame->view()->scrollableAreas()->size(); 1603 count += frame->view()->scrollableAreas()->size();
1604 1604
1605 for (LocalFrame* child = frame->tree().firstChild(); child; child = child->t ree().nextSibling()) { 1605 for (Frame* child = frame->tree().firstChild(); child; child = child->tree() .nextSibling()) {
1606 if (child->view() && child->view()->scrollableAreas()) 1606 if (child->isLocalFrame() && toLocalFrame(child)->view() && toLocalFrame (child)->view()->scrollableAreas())
1607 count += child->view()->scrollableAreas()->size(); 1607 count += toLocalFrame(child)->view()->scrollableAreas()->size();
1608 } 1608 }
1609 1609
1610 return count; 1610 return count;
1611 } 1611 }
1612 1612
1613 bool Internals::isPageBoxVisible(Document* document, int pageNumber, ExceptionSt ate& exceptionState) 1613 bool Internals::isPageBoxVisible(Document* document, int pageNumber, ExceptionSt ate& exceptionState)
1614 { 1614 {
1615 if (!document) { 1615 if (!document) {
1616 exceptionState.throwDOMException(InvalidAccessError, "No context documen t is available."); 1616 exceptionState.throwDOMException(InvalidAccessError, "No context documen t is available.");
1617 return false; 1617 return false;
(...skipping 750 matching lines...) Expand 10 before | Expand all | Expand 10 after
2368 } else if (type == "none") { 2368 } else if (type == "none") {
2369 webtype = blink::ConnectionTypeNone; 2369 webtype = blink::ConnectionTypeNone;
2370 } else { 2370 } else {
2371 exceptionState.throwDOMException(NotFoundError, ExceptionMessages::faile dToEnumerate("connection type", type)); 2371 exceptionState.throwDOMException(NotFoundError, ExceptionMessages::faile dToEnumerate("connection type", type));
2372 return; 2372 return;
2373 } 2373 }
2374 networkStateNotifier().setWebConnectionTypeForTest(webtype); 2374 networkStateNotifier().setWebConnectionTypeForTest(webtype);
2375 } 2375 }
2376 2376
2377 } // namespace WebCore 2377 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/storage/StorageArea.cpp ('k') | Source/modules/geolocation/testing/InternalsGeolocation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698