Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1358)

Side by Side Diff: Source/core/page/Page.cpp

Issue 317493002: Change FrameTree to return Frames instead of LocalFrames. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: dcheng's comment addressed Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/page/FrameTree.cpp ('k') | Source/core/rendering/FastTextAutosizer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All R ights Reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All R ights Reserved.
3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 545 matching lines...) Expand 10 before | Expand all | Expand 10 after
556 m_inspectorController->didCommitLoadForMainFrame(); 556 m_inspectorController->didCommitLoadForMainFrame();
557 } 557 }
558 } 558 }
559 559
560 void Page::acceptLanguagesChanged() 560 void Page::acceptLanguagesChanged()
561 { 561 {
562 Vector< RefPtr<LocalFrame> > frames; 562 Vector< RefPtr<LocalFrame> > frames;
563 563
564 // Even though we don't fire an event from here, the DOMWindow's will fire 564 // Even though we don't fire an event from here, the DOMWindow's will fire
565 // an event so we keep the frames alive until we are done. 565 // an event so we keep the frames alive until we are done.
566 for (LocalFrame* frame = mainFrame(); frame; frame = frame->tree().traverseN ext()) 566 for (Frame* frame = mainFrame(); frame; frame = frame->tree().traverseNext() ) {
567 frames.append(frame); 567 if (frame->isLocalFrame())
568 frames.append(toLocalFrame(frame));
569 }
568 570
569 for (unsigned i = 0; i < frames.size(); ++i) 571 for (unsigned i = 0; i < frames.size(); ++i)
570 frames[i]->domWindow()->acceptLanguagesChanged(); 572 frames[i]->domWindow()->acceptLanguagesChanged();
571 } 573 }
572 574
573 PageLifecycleNotifier& Page::lifecycleNotifier() 575 PageLifecycleNotifier& Page::lifecycleNotifier()
574 { 576 {
575 return static_cast<PageLifecycleNotifier&>(LifecycleContext<Page>::lifecycle Notifier()); 577 return static_cast<PageLifecycleNotifier&>(LifecycleContext<Page>::lifecycle Notifier());
576 } 578 }
577 579
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
629 , spellCheckerClient(0) 631 , spellCheckerClient(0)
630 , storageClient(0) 632 , storageClient(0)
631 { 633 {
632 } 634 }
633 635
634 Page::PageClients::~PageClients() 636 Page::PageClients::~PageClients()
635 { 637 {
636 } 638 }
637 639
638 } // namespace WebCore 640 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/page/FrameTree.cpp ('k') | Source/core/rendering/FastTextAutosizer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698