mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc - Issue 317433004: Get view manager client lib unit test harness to run again. Does not get any individual tests worki…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc

Issue 317433004: Get view manager client lib unit test harness to run again. Does not get any individual tests worki… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/services/public/cpp/view_manager/lib/view_manager.cc ('K') | « mojo/services/public/cpp/view_manager/lib/view_manager_private.h ('k') | mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc » ('j') | mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc

diff --git a/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc b/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc

index 7d1d489ef51e0db3a7ee2b08152a66f68717cf57..258aeaed32dce0428722624406217ed5766ff108 100644

--- a/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc

+++ b/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc

@@ -560,12 +560,10 @@ void ViewManagerSynchronizer::OnViewManagerConnectionEstablished(

connection_id_ = connection_id;

next_server_change_id_ = next_server_change_id;

- ViewManagerPrivate(view_manager()).set_root(

- BuildNodeTree(view_manager(), nodes));

+ ViewManagerPrivate private_manager(view_manager());

+ private_manager.set_root(BuildNodeTree(view_manager(), nodes));

Sync();

- base::MessageLoop::current()->Quit();

+ private_manager.NotifyReady();

}

void ViewManagerSynchronizer::OnServerChangeIdAdvanced(