Issue 317433003: Remove NOTIFICATION_EXTENSION_UNINSTALLED from extension_enable_flow.*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 317433003: Remove NOTIFICATION_EXTENSION_UNINSTALLED from extension_enable_flow.* (Closed)

Created:
6 years, 6 months ago by limasdf

Modified:
6 years, 6 months ago

Reviewers:
benwells

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove NOTIFICATION_EXTENSION_UNINSTALLED from extension_enable_flow.*. and use ExtensionRegisty instead. BUG=376293 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274796

Patch Set 1 : #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -21 lines)			Patch
	M	chrome/browser/ui/extensions/extension_enable_flow.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/extensions/extension_enable_flow.cc	View		2 chunks	+13 lines, -21 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

limasdf

Ben, PTAL. https://codereview.chromium.org/317433003/diff/40001/chrome/browser/ui/extensions/extension_enable_flow.cc File chrome/browser/ui/extensions/extension_enable_flow.cc (right): https://codereview.chromium.org/317433003/diff/40001/chrome/browser/ui/extensions/extension_enable_flow.cc#newcode123 chrome/browser/ui/extensions/extension_enable_flow.cc:123: extension_registry_observer_.RemoveAll(); I think this is necessary. and ...

6 years, 6 months ago (2014-06-03 19:27:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/317433003/40001

6 years, 6 months ago (2014-06-04 04:40:59 UTC) #4

Message was sent while issue was closed.

Change committed as 274796

Expand Messages | Collapse Messages