Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 317423003: Update some gyp targets to use dex_action.gypi (Closed)

Created:
6 years, 6 months ago by cjhopman
Modified:
6 years, 6 months ago
Reviewers:
nyquist
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Update some gyp targets to use dex_action.gypi This makes the way that we invoke dex more consistent (and easier to change). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276518

Patch Set 1 #

Patch Set 2 : Remove unrelated whitespace cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -29 lines) Patch
M build/java_prebuilt.gypi View 1 chunk +7 lines, -15 lines 0 comments Download
M build/uiautomator_test.gypi View 1 chunk +7 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
cjhopman
nyquist: *
6 years, 6 months ago (2014-06-06 20:36:14 UTC) #1
nyquist
lgtm
6 years, 6 months ago (2014-06-09 01:35:55 UTC) #2
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 6 months ago (2014-06-09 17:37:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/317423003/1
6 years, 6 months ago (2014-06-09 17:38:52 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 05:46:44 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 05:54:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/14779)
6 years, 6 months ago (2014-06-10 05:54:11 UTC) #7
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 6 months ago (2014-06-10 17:25:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/317423003/20001
6 years, 6 months ago (2014-06-10 17:26:21 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 01:53:26 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 07:55:12 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/18826)
6 years, 6 months ago (2014-06-11 07:55:13 UTC) #12
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 6 months ago (2014-06-11 21:20:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/317423003/20001
6 years, 6 months ago (2014-06-11 21:22:16 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 03:40:44 UTC) #15
Message was sent while issue was closed.
Change committed as 276518

Powered by Google App Engine
This is Rietveld 408576698