Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 317413002: Dump request content after RenderFrameImpl::willSendRequest (Closed)

Created:
6 years, 6 months ago by clamy
Modified:
6 years, 6 months ago
Reviewers:
jam, ppi
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Dump request content after RenderFrameImpl::willSendRequest In layout tests in blink, WebTestProxyBase::WillSendRequest is used to dump the content of a request and compare it to an expected output. It should do so after RenderFrameImpl::willSendRequest has run, since we are moving the setting of parameters to RenderFrameImpl::willSendRequest. BUG=376025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
clamy
@ppi: PTAL
6 years, 6 months ago (2014-06-06 16:29:07 UTC) #1
ppi
lgtm, thanks!
6 years, 6 months ago (2014-06-10 14:24:47 UTC) #2
clamy
@jam: PTAL @ppi: thanks!
6 years, 6 months ago (2014-06-10 15:13:30 UTC) #3
jam
lgtm
6 years, 6 months ago (2014-06-10 16:26:23 UTC) #4
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-10 16:32:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/317413002/1
6 years, 6 months ago (2014-06-10 16:34:02 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 00:05:19 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 06:05:58 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/18791)
6 years, 6 months ago (2014-06-11 06:05:59 UTC) #9
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-11 09:07:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/317413002/1
6 years, 6 months ago (2014-06-11 09:10:12 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 11:01:28 UTC) #12
Message was sent while issue was closed.
Change committed as 276340

Powered by Google App Engine
This is Rietveld 408576698