|
|
Pass both hostname and port into SSLClientSocket
This fixes various TODOs regarding not passing a port along with a hostname.
Most notably, host_and_port in SSLCertRequestInfo now actually contains the
port. We also appropriately include it in the SSL peer ID on OS X.
This does result in some UI change, in that we now display the port on
certificate selection dialogs. We should probably display the EV name, but we
cannot verify certificates early enough for now.
BUG=none
TEST=none
Looks like someone else beat me to it.
http://codereview.chromium.org/4339001
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+124 lines, -87 lines) |
Patch |
 |
M |
chrome/browser/cocoa/ssl_client_certificate_selector.mm
|
View
|
|
2 chunks |
+13 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/net/preconnect.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
jingle/notifier/base/chrome_async_socket.cc
|
View
|
|
2 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
 |
M |
jingle/notifier/communicator/ssl_socket_adapter.cc
|
View
|
|
2 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
 |
M |
net/base/ssl_cert_request_info.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
net/http/http_network_transaction.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
net/socket/client_socket_factory.h
|
View
|
|
3 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
net/socket/client_socket_factory.cc
|
View
|
|
3 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
 |
M |
net/socket/socket_test_util.h
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
net/socket/socket_test_util.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
net/socket/ssl_client_socket_mac.h
|
View
|
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
net/socket/ssl_client_socket_mac.cc
|
View
|
|
6 chunks |
+9 lines, -8 lines |
0 comments
|
Download
|
 |
M |
net/socket/ssl_client_socket_mac_factory.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
net/socket/ssl_client_socket_mac_factory.cc
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
net/socket/ssl_client_socket_nss.h
|
View
|
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
net/socket/ssl_client_socket_nss.cc
|
View
|
|
8 chunks |
+9 lines, -12 lines |
0 comments
|
Download
|
 |
M |
net/socket/ssl_client_socket_nss_factory.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
net/socket/ssl_client_socket_nss_factory.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
net/socket/ssl_client_socket_pool.h
|
View
|
|
4 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
net/socket/ssl_client_socket_pool.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
net/socket/ssl_client_socket_pool_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
net/socket/ssl_client_socket_unittest.cc
|
View
|
|
10 chunks |
+20 lines, -12 lines |
0 comments
|
Download
|
 |
M |
net/socket/ssl_client_socket_win.h
|
View
|
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
net/socket/ssl_client_socket_win.cc
|
View
|
|
5 chunks |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
net/socket_stream/socket_stream.cc
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
net/spdy/spdy_session.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
remoting/jingle_glue/ssl_socket_adapter.cc
|
View
|
|
2 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|