Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 317393002: Fixed Ash.WindowSelector.TimeInOverview UMA metric reporting wrong time. (Closed)

Created:
6 years, 6 months ago by Nina
Modified:
6 years, 6 months ago
Reviewers:
flackr, tdanderson
CC:
chromium-reviews, tdanderson+overview_chromium.org, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixed Ash.WindowSelector.TimeInOverview UMA metric reporting wrong time. BUG=381703 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275610

Patch Set 1 #

Patch Set 2 : Rebased change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ash/wm/overview/window_selector.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nina
Hi Rob, here is the fix for the overview timer.
6 years, 6 months ago (2014-06-06 15:32:37 UTC) #1
flackr
lgtm
6 years, 6 months ago (2014-06-06 15:33:22 UTC) #2
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 6 months ago (2014-06-06 19:20:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nsatragno@chromium.org/317393002/20001
6 years, 6 months ago (2014-06-06 19:22:14 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 23:48:56 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 04:19:50 UTC) #6
Message was sent while issue was closed.
Change committed as 275610

Powered by Google App Engine
This is Rietveld 408576698