Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 317383002: Revert of [Android] Remove hardware menu button dragging support. (Closed)

Created:
6 years, 6 months ago by johnme
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of [Android] Remove hardware menu button dragging support. (https://codereview.chromium.org/317083005/) Reason for revert: AppMenuHandler.hardwareMenuButtonUp is still used by clank/java/apps/chrome/src/com/google/android/apps/chrome/Main.java:1572, hence this is causing instrumentation-yakju-clankium-tot and clang-clankium-tot-builder to fail to compile with the following error: ../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/Main.java:1572: cannot find symbol symbol : method hardwareMenuButtonUp() location: class org.chromium.chrome.browser.appmenu.AppMenuHandler mAppMenuHandler.hardwareMenuButtonUp(); Original issue's description: > [Android] Remove hardware menu button dragging support. > > This code path was broken sometime within a year, and we don't think > it's worth to support this more. > > BUG=366154 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275395 TBR=aurimas@chromium.org,tedchoc@chromium.org,kkimlabs@chromium.org NOTREECHECKS=true NOTRY=true BUG=366154 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -23 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java View 12 chunks +224 lines, -18 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java View 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
johnme
Created Revert of [Android] Remove hardware menu button dragging support.
6 years, 6 months ago (2014-06-06 15:11:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnme@chromium.org/317383002/1
6 years, 6 months ago (2014-06-06 15:11:51 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 15:13:01 UTC) #3
Message was sent while issue was closed.
Change committed as 275447

Powered by Google App Engine
This is Rietveld 408576698