LayoutTests/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls.html - Issue 317373007: Report correct touch hit rects for fullscreen HTML5 video on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls.html

Issue 317373007: Report correct touch hit rects for fullscreen HTML5 video on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update test expectations Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <link rel="stylesheet" href="../fast/events/touch/resources/compositor-touch-hit -rects.css">

	5 </head>

	6 <body>

	7 <p id="discription">

	8 This test makes sure that touch hit rects are reported for fullscreen HTML5

	9 video control elements when
	Rick Byers 2014/06/12 15:47:20 I'm not sure what "document handler is false" mean I'm not sure what "document handler is false" means, and since this test runs both with and without overlayFullscreenVideoEnabled I'd simplify the description. Eg. "... video control elements even when there is a document handler".
	10 RuntimeEnabledFeatures::overlayFullscreenVideoEnabled() is true and the

	11 document handler if false.

	12 </p>

	13 <video id="video" width="300"></video>

	14 <script src="full-screen-test.js"></script>

	15 <script src="../fast/events/touch/resources/compositor-touch-hit-rects.js"></scr ipt>

	16 <script>

	17 var log = consoleWrite;

	18

	19 if (window.testRunner)

	20 testRunner.dumpAsText();

	21

	22 window.onload = function () {

	23 document.addEventListener('touchstart', function() { });

	24

	25 consoleWrite("Should have single rect on document before fullscreen");

	26 logRects('handler');

	27

	28 waitForEvent(document, 'webkitfullscreenchange', function() {

	29 if (window.internals.runtimeFlags.overlayFullscreenVideoEnabled)

	30 consoleWrite("Should report another rect which is not on the documen t");

	31 else

	32 consoleWrite("Should keep rect on document");

	33 logRects('handler');

	34 endTest();

	35 });

	36

	37 runWithKeyDown(function(){document.querySelector('#video').webkitRequestFull Screen()});

	38 }

	39 </script>

	40 </body>

	41 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt » ('j') | no next file with comments »