Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: Source/core/rendering/compositing/RenderLayerCompositor.h

Issue 317373007: Report correct touch hit rects for fullscreen HTML5 video on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add virtual test Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 bool canBeComposited(const RenderLayer*) const; 183 bool canBeComposited(const RenderLayer*) const;
184 184
185 // FIXME: Move allocateOrClearCompositedLayerMapping to CompositingLayerAssi gner once we've fixed 185 // FIXME: Move allocateOrClearCompositedLayerMapping to CompositingLayerAssi gner once we've fixed
186 // the compositing chicken/egg issues. 186 // the compositing chicken/egg issues.
187 bool allocateOrClearCompositedLayerMapping(RenderLayer*, CompositingStateTra nsitionType compositedLayerUpdate); 187 bool allocateOrClearCompositedLayerMapping(RenderLayer*, CompositingStateTra nsitionType compositedLayerUpdate);
188 188
189 void updateDirectCompositingReasons(RenderLayer*); 189 void updateDirectCompositingReasons(RenderLayer*);
190 190
191 void setOverlayLayer(GraphicsLayer*); 191 void setOverlayLayer(GraphicsLayer*);
192 192
193 bool inOverlayFullscreenVideo() const { return m_inOverlayFullscreenVideo; }
194
193 private: 195 private:
194 class OverlapMap; 196 class OverlapMap;
195 197
196 #if ASSERT_ENABLED 198 #if ASSERT_ENABLED
197 void assertNoUnresolvedDirtyBits(); 199 void assertNoUnresolvedDirtyBits();
198 #endif 200 #endif
199 201
200 // Make updates to the layer based on viewport-constrained properties such a s position:fixed. This can in turn affect 202 // Make updates to the layer based on viewport-constrained properties such a s position:fixed. This can in turn affect
201 // compositing. 203 // compositing.
202 bool updateLayerIfViewportConstrained(RenderLayer*); 204 bool updateLayerIfViewportConstrained(RenderLayer*);
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 bool requiresVerticalScrollbarLayer() const; 239 bool requiresVerticalScrollbarLayer() const;
238 bool requiresScrollCornerLayer() const; 240 bool requiresScrollCornerLayer() const;
239 #if USE(RUBBER_BANDING) 241 #if USE(RUBBER_BANDING)
240 bool requiresOverhangLayers() const; 242 bool requiresOverhangLayers() const;
241 #endif 243 #endif
242 244
243 void applyUpdateLayerCompositingStateChickenEggHacks(RenderLayer*, Compositi ngStateTransitionType compositedLayerUpdate); 245 void applyUpdateLayerCompositingStateChickenEggHacks(RenderLayer*, Compositi ngStateTransitionType compositedLayerUpdate);
244 246
245 DocumentLifecycle& lifecycle() const; 247 DocumentLifecycle& lifecycle() const;
246 248
247 void applyOverlayFullscreenVideoAdjustment();
248
249 RenderView& m_renderView; 249 RenderView& m_renderView;
250 OwnPtr<GraphicsLayer> m_rootContentLayer; 250 OwnPtr<GraphicsLayer> m_rootContentLayer;
251 OwnPtr<GraphicsLayer> m_rootTransformLayer; 251 OwnPtr<GraphicsLayer> m_rootTransformLayer;
252 252
253 CompositingReasonFinder m_compositingReasonFinder; 253 CompositingReasonFinder m_compositingReasonFinder;
254 254
255 CompositingUpdateType m_pendingUpdateType; 255 CompositingUpdateType m_pendingUpdateType;
256 256
257 bool m_hasAcceleratedCompositing; 257 bool m_hasAcceleratedCompositing;
258 bool m_compositing; 258 bool m_compositing;
(...skipping 18 matching lines...) Expand all
277 // Enclosing layer for overflow controls and the clipping layer 277 // Enclosing layer for overflow controls and the clipping layer
278 OwnPtr<GraphicsLayer> m_overflowControlsHostLayer; 278 OwnPtr<GraphicsLayer> m_overflowControlsHostLayer;
279 279
280 // Layers for overflow controls 280 // Layers for overflow controls
281 OwnPtr<GraphicsLayer> m_layerForHorizontalScrollbar; 281 OwnPtr<GraphicsLayer> m_layerForHorizontalScrollbar;
282 OwnPtr<GraphicsLayer> m_layerForVerticalScrollbar; 282 OwnPtr<GraphicsLayer> m_layerForVerticalScrollbar;
283 OwnPtr<GraphicsLayer> m_layerForScrollCorner; 283 OwnPtr<GraphicsLayer> m_layerForScrollCorner;
284 #if USE(RUBBER_BANDING) 284 #if USE(RUBBER_BANDING)
285 OwnPtr<GraphicsLayer> m_layerForOverhangShadow; 285 OwnPtr<GraphicsLayer> m_layerForOverhangShadow;
286 #endif 286 #endif
287
288 bool m_inOverlayFullscreenVideo;
289 void applyOverlayFullscreenVideoAdjustment();
Rick Byers 2014/06/10 20:02:24 we usually list all the methods before the fields,
287 }; 290 };
288 291
289 } // namespace WebCore 292 } // namespace WebCore
290 293
291 #endif // RenderLayerCompositor_h 294 #endif // RenderLayerCompositor_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698