Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10630)

Unified Diff: components/bookmarks/browser/bookmark_client.h

Issue 317333004: Added BookmarkClient::CanBeEditedByUser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added TODO Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_client.h
diff --git a/components/bookmarks/browser/bookmark_client.h b/components/bookmarks/browser/bookmark_client.h
index 97bb04771919df7d936a6067558c90531bec7010..fa0dc637ae0d0ee22176ac96730751316a992b83 100644
--- a/components/bookmarks/browser/bookmark_client.h
+++ b/components/bookmarks/browser/bookmark_client.h
@@ -69,18 +69,17 @@ class BookmarkClient {
// task will be invoked in the Profile's IO task runner.
virtual bookmarks::LoadExtraCallback GetLoadExtraNodesCallback() = 0;
- // Checks if the children of the given permanent |node| can be removed from
- // the bookmark model.
- virtual bool CanRemovePermanentNodeChildren(const BookmarkNode* node) = 0;
-
- // Checks if the |permanent_node| can have its title updated.
+ // Returns true if the |permanent_node| can have its title updated.
virtual bool CanSetPermanentNodeTitle(const BookmarkNode* permanent_node) = 0;
- // Checks if |node| should sync.
+ // Returns true if |node| should sync.
virtual bool CanSyncNode(const BookmarkNode* node) = 0;
- // Checks if the children of |parent| can be reordered or sorted.
- virtual bool CanReorderChildren(const BookmarkNode* parent) = 0;
+ // Returns true if this node can be edited by the user.
+ // TODO(joaodasilva): the model should check this more aggressively, and
+ // should give the client a means to temporarily disable those checks.
+ // http://crbug.com/49598
+ virtual bool CanBeEditedByUser(const BookmarkNode* node) = 0;
protected:
virtual ~BookmarkClient() {}
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc ('k') | components/bookmarks/browser/bookmark_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698