Issue 317303002: Removes remaining parents observations at dtor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 317303002: Removes remaining parents observations at dtor. (Closed)

Created:
6 years, 6 months ago by Jun Mukai

Modified:
6 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Removes remaining parents observations at dtor. In the case of the reported crash, we doesn't set the transient parent, which means we cannot unregister the window observer. BUG=373522 R=erg@chromium.org TEST=see the bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275507

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/317303002/1

6 years, 6 months ago (2014-06-06 17:43:57 UTC) #4

Message was sent while issue was closed.

Change committed as 275507