Issue 3173020: FBTF: Remove unneeded #includes of <string> and <vector> from src/app and src/base.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3173020: FBTF: Remove unneeded #includes of <string> and <vector> from src/app and src/base. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by viettrungluu

Modified:
3 years, 11 months ago

Reviewers:
Lei Zhang, Miranda Callahan, Elliot Glaysher

CC:
chromium-reviews, brettw-cc_chromium.org

Visibility:
Public.

FBTF: Remove unneeded #includes of <string> and <vector> from src/app and src/base. BUG=none TEST=builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56144

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -29 lines)			Patch
M	app/clipboard/scoped_clipboard_writer.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	app/gtk_util.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	app/os_exchange_data.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	app/os_exchange_data_provider_gtk.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	app/test_suite.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	app/theme_provider.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	base/debug_util.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	base/event_recorder.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	base/i18n/file_util_icu.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	base/i18n/number_formatting.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	base/i18n/word_iterator.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	base/observer_list_threadsafe.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	base/resource_util.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	base/test/test_file_util.h	View		2 chunks	+1 line, -3 lines	0 comments	Download

Trybot results: win

Total messages: 2 (0 generated)

Miranda Callahan

4 years, 9 months ago (2010-08-14 17:42:38 UTC) #2

On 2010/08/14 07:17:17, viettrungluu wrote:
> 

LGTM!