Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 317273004: Create Tracing{Timeline}Model in TimelinePanel constructor (Closed)

Created:
6 years, 6 months ago by yurys
Modified:
6 years, 6 months ago
Reviewers:
caseq, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Create Tracing{Timeline}Model in TimelinePanel constructor start/stop recording logic for trace events moved into TracingTimelineModel. BUG=361045 R=caseq@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175649

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 5

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -41 lines) Patch
M LayoutTests/inspector/layers/tracing-layer-tree.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 2 8 chunks +22 lines, -38 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 4 chunks +37 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
6 years, 6 months ago (2014-06-06 08:34:03 UTC) #1
caseq
lgtm https://codereview.chromium.org/317273004/diff/20001/Source/devtools/front_end/timeline/TimelinePanel.js File Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/317273004/diff/20001/Source/devtools/front_end/timeline/TimelinePanel.js#newcode264 Source/devtools/front_end/timeline/TimelinePanel.js:264: this._lazyFrameModel.addTraceEvents(this._tracingTimelineModel.inspectedTargetEvents(), this._tracingModel.sessionId() || ""); nit: this could as ...
6 years, 6 months ago (2014-06-06 09:03:18 UTC) #2
yurys
https://codereview.chromium.org/317273004/diff/20001/Source/devtools/front_end/timeline/TimelinePanel.js File Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/317273004/diff/20001/Source/devtools/front_end/timeline/TimelinePanel.js#newcode264 Source/devtools/front_end/timeline/TimelinePanel.js:264: this._lazyFrameModel.addTraceEvents(this._tracingTimelineModel.inspectedTargetEvents(), this._tracingModel.sessionId() || ""); On 2014/06/06 09:03:18, caseq wrote: ...
6 years, 6 months ago (2014-06-06 09:13:57 UTC) #3
yurys
https://codereview.chromium.org/317273004/diff/20001/Source/devtools/front_end/timeline/TimelinePanel.js File Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/317273004/diff/20001/Source/devtools/front_end/timeline/TimelinePanel.js#newcode264 Source/devtools/front_end/timeline/TimelinePanel.js:264: this._lazyFrameModel.addTraceEvents(this._tracingTimelineModel.inspectedTargetEvents(), this._tracingModel.sessionId() || ""); On 2014/06/06 09:13:56, yurys wrote: ...
6 years, 6 months ago (2014-06-06 09:16:52 UTC) #4
yurys
6 years, 6 months ago (2014-06-06 09:21:24 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r175649 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698