Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 317273003: Make a docked panel visible on all desktops on KDE (Closed)

Created:
6 years, 6 months ago by pkotwicz
Modified:
6 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tdanderson+views_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, tfarina, ben+views_chromium.org
Visibility:
Public.

Description

Make a docked panel visible on all desktops on KDE BUG=380378 TEST=Manual, see bug R=erg TBR=sadrul (For trivial change to ui/base/x/x11_util.h)

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M ui/base/x/x11_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 3 chunks +31 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
pkotwicz
Elliot, can you please take a look? SetVisibleOnAllWorkspaces() now has the same behavior as gdk_window_stick() ...
6 years, 6 months ago (2014-06-06 00:38:43 UTC) #1
Elliot Glaysher
lgtm
6 years, 6 months ago (2014-06-06 01:03:42 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-06 14:09:31 UTC) #3
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-06 14:09:34 UTC) #4
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-06 14:10:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/317273003/20001
6 years, 6 months ago (2014-06-06 14:10:25 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 17:40:38 UTC) #7
commit-bot: I haz the power
Could not make sense out of svn commit message.
6 years, 6 months ago (2014-06-06 17:40:39 UTC) #8
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-08 00:54:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/317273003/20001
6 years, 6 months ago (2014-06-08 00:54:53 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-08 02:07:54 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-08 02:07:55 UTC) #12 
Failed to apply patch for ui/base/x/x11_util.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ui/base/x/x11_util.h
  Hunk #1 FAILED at 102.
  1 out of 1 hunk FAILED -- saving rejects to file ui/base/x/x11_util.h.rej

Patch:       ui/base/x/x11_util.h
Index: ui/base/x/x11_util.h
diff --git a/ui/base/x/x11_util.h b/ui/base/x/x11_util.h
index
a349fdaa91ddb6a1500cac672c8c1b667a87b0b6..3f3830adadcdbefcbaa85d65edef6fdb386888cc
100644
--- a/ui/base/x/x11_util.h
+++ b/ui/base/x/x11_util.h
@@ -102,7 +102,7 @@ UI_BASE_EXPORT bool IsShapeExtensionAvailable();
 UI_BASE_EXPORT XID GetX11RootWindow();
 
 // Returns the user's current desktop.
-bool GetCurrentDesktop(int* desktop);
+UI_BASE_EXPORT bool GetCurrentDesktop(int* desktop);
 
 enum HideTitlebarWhenMaximized {
   SHOW_TITLEBAR_WHEN_MAXIMIZED = 0,

Powered by Google App Engine
This is Rietveld 408576698