Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 317253004: test_runner: Migrate MockWebAudioDevice to our Chromium C++ style. (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 6 months ago
CC:
chromium-reviews, jochen (gone - plz use gerrit), jam
Visibility:
Public.

Description

test_runner: Migrate MockWebAudioDevice to our Chromium C++ style. Changes: 1) Run clang-format through source and header files. 2) Fix data member variables to use unix_hacker_ style. 3) Rename file name to mock_web_audio_device. BUG=331299 TEST=content_unittests, content_shell. No functional changes TBR=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275421

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -97 lines) Patch
M content/content_shell.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
D content/shell/renderer/test_runner/MockWebAudioDevice.h View 1 chunk +0 lines, -31 lines 0 comments Download
D content/shell/renderer/test_runner/MockWebAudioDevice.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestInterfaces.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/renderer/test_runner/mock_web_audio_device.h View 1 1 chunk +15 lines, -15 lines 0 comments Download
A + content/shell/renderer/test_runner/mock_web_audio_device.cc View 1 1 chunk +8 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
TBRing...(please, rubber stamp). thanks,
6 years, 6 months ago (2014-06-06 07:15:14 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-06 07:15:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/317253004/20001
6 years, 6 months ago (2014-06-06 07:17:45 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 6 months ago (2014-06-06 07:29:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 11:51:13 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 13:21:34 UTC) #6
Message was sent while issue was closed.
Change committed as 275421

Powered by Google App Engine
This is Rietveld 408576698