Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 317243004: Fix the print preview dialog frame. (Closed)

Created:
6 years, 6 months ago by msw
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix the print preview dialog frame. My r275303 mistakenly removed a function override. (it was a reasonable change for an earlier patch set) Restore ConstrainedWebDialogDelegateViewViews code. (uses dialog frame views via CreateNonClientFrameView) BUG=381524 TEST=Print preview dialog frame is back to normal. TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
msw
Hey Scott, please take a look as you have time, thanks.
6 years, 6 months ago (2014-06-06 18:58:51 UTC) #1
msw
The CQ bit was checked by msw@chromium.org
6 years, 6 months ago (2014-06-06 18:58:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/317243004/1
6 years, 6 months ago (2014-06-06 19:01:11 UTC) #3
sky
LGTM
6 years, 6 months ago (2014-06-06 19:54:34 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 00:01:07 UTC) #5
Message was sent while issue was closed.
Change committed as 275559

Powered by Google App Engine
This is Rietveld 408576698