Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 317203004: Removed --disable-background-mode/restore-background-contents flags. (Closed)

Created:
6 years, 6 months ago by Andrew T Wilson (Slow)
Modified:
6 years, 6 months ago
Reviewers:
battre, Scott Byer
CC:
chromium-reviews
Visibility:
Public.

Description

Removed --disable-background-mode/restore-background-contents flags. BUG=350898 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275698

Patch Set 1 #

Patch Set 2 : Removed deprecated command line switch from cloud_print #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M chrome/browser/background/background_contents_service.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M cloud_print/service/win/chrome_launcher.cc View 1 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Andrew T Wilson (Slow)
PTAL
6 years, 6 months ago (2014-06-06 12:04:38 UTC) #1
battre
lgtm
6 years, 6 months ago (2014-06-06 12:15:07 UTC) #2
Andrew T Wilson (Slow)
Scott, PTAL at chrome_print
6 years, 6 months ago (2014-06-06 16:13:02 UTC) #3
Scott Byer
lgtm
6 years, 6 months ago (2014-06-06 17:20:07 UTC) #4
Andrew T Wilson (Slow)
The CQ bit was checked by atwilson@chromium.org
6 years, 6 months ago (2014-06-07 18:18:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/317203004/20001
6 years, 6 months ago (2014-06-07 18:19:56 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 18:45:45 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 20:36:49 UTC) #8
Message was sent while issue was closed.
Change committed as 275698

Powered by Google App Engine
This is Rietveld 408576698