Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 317193002: Chromium should no longer need the legacy SkCanvas::drawPicture interface (Closed)

Created:
6 years, 6 months ago by robertphillips
Modified:
6 years, 6 months ago
Reviewers:
jvanverth1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Chromium should no longer need the legacy SkCanvas::drawPicture interface With: Switch Blink to using new Skia SkCanvas::drawPicture method - https://codereview.chromium.org/316863003/ Switch Chromium to new Skia SkCanvas::drawPicture method - https://codereview.chromium.org/315963003/ Chromium/Blink should no longer need this flag. Note: this patch cannot be landed until the Blink change rolls into Chromium. Committed: https://skia.googlesource.com/skia/+/5713352a64936428d37a721382d021f4a9002172

Patch Set 1 #

Patch Set 2 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M gyp/skia_for_chromium_defines.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
robertphillips
6 years, 6 months ago (2014-06-05 15:26:26 UTC) #1
jvanverth1
LGTM. Please hold off on committing until the Blink change lands in Chromium.
6 years, 6 months ago (2014-06-05 15:37:00 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-06 18:11:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/317193002/1
6 years, 6 months ago (2014-06-06 18:12:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 18:12:13 UTC) #5
commit-bot: I haz the power
Failed to apply patch for gyp/skia_for_chromium_defines.gypi: While running git apply --index -p1; error: patch failed: ...
6 years, 6 months ago (2014-06-06 18:12:14 UTC) #6
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-08 19:52:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/317193002/20001
6 years, 6 months ago (2014-06-08 19:53:13 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-08 20:18:00 UTC) #9
Message was sent while issue was closed.
Change committed as 5713352a64936428d37a721382d021f4a9002172

Powered by Google App Engine
This is Rietveld 408576698