Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
6 years, 6 months ago by Peter Beverloo Modified:
6 years, 6 months ago Reviewers:
dcheng CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionBlink roll 175512:175568
TBR=dcheng@chromium.org
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275164
Patch Set 1 #Messages
Total messages: 10 (0 generated)
The CQ bit was checked by peter@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/317183002/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by peter@chromium.org
On 2014/06/05 13:24:34, I haz the power (commit-bot) wrote: > No LGTM from a valid reviewer yet. Only full committers are accepted. > Even if an LGTM may have been provided, it was from a non-committer or > a provisional committer, _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. grmbl. one day I will be able to properly use the safely-roll-deps.py script :-).
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/317183002/1
Message was sent while issue was closed.
Change committed as 275164
Message was sent while issue was closed.
On 2014/06/05 16:55:15, I haz the power (commit-bot) wrote: > Change committed as 275164 Turns out this needed a landmine, due to generated file move in: Separate the generated files from core and modules to their own sub-dirs. (Closed) https://codereview.chromium.org/314783004/ This thus caused build failures on subsequent CLs that changed the generated files: https://code.google.com/p/chromium/issues/detail?id=381111 Ex post fix posted: Add landmine due to generated file move in Blink r175513 https://codereview.chromium.org/316343003/ ...and issue documented at: http://www.chromium.org/Home/chromium-clobber-landmines |
