Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 317183002: Blink roll 175512:175568 (Closed)

Created:
6 years, 6 months ago by Peter Beverloo
Modified:
6 years, 6 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Peter Beverloo
6 years, 6 months ago (2014-06-05 13:23:15 UTC) #1
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 6 months ago (2014-06-05 13:23:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/317183002/1
6 years, 6 months ago (2014-06-05 13:24:33 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 13:24:34 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-05 13:24:34 UTC) #5
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 6 months ago (2014-06-05 13:25:11 UTC) #6
Peter Beverloo
On 2014/06/05 13:24:34, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 6 months ago (2014-06-05 13:25:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/317183002/1
6 years, 6 months ago (2014-06-05 13:26:02 UTC) #8
commit-bot: I haz the power
Change committed as 275164
6 years, 6 months ago (2014-06-05 16:55:15 UTC) #9
Nils Barth (inactive)
6 years, 6 months ago (2014-06-06 03:11:12 UTC) #10
Message was sent while issue was closed.
On 2014/06/05 16:55:15, I haz the power (commit-bot) wrote:
> Change committed as 275164

Turns out this needed a landmine, due to generated file move in:
Separate the generated files from core and modules to their own sub-dirs.
(Closed)
https://codereview.chromium.org/314783004/

This thus caused build failures on subsequent CLs that changed the generated
files:
https://code.google.com/p/chromium/issues/detail?id=381111

Ex post fix posted:
Add landmine due to generated file move in Blink r175513
https://codereview.chromium.org/316343003/

...and issue documented at:
http://www.chromium.org/Home/chromium-clobber-landmines

Powered by Google App Engine
This is Rietveld 408576698