Issue 317163008: Make Telemetry more robust during ephemeral port handshake.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 317163008: Make Telemetry more robust during ephemeral port handshake. (Closed)

Created:
6 years, 6 months ago by Ken Russell (switch to Gerrit)

Modified:
6 years, 6 months ago

Reviewers:
tonyg

CC:
chromium-reviews, telemetry+watch_chromium.org, dtu, nednguyen(REVIEW IN OTHER ACC)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Make Telemetry more robust during ephemeral port handshake. On Windows, if the browser is still writing the DevToolsActivePort file when Telemetry attempts to open it, Python will raise an IOError. Make the Telemetry-side code more robust when reading the file containing the port. BUG=372560 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275620

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -4 lines)			Patch
	M	tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py	View		1 chunk	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/317163008/1

6 years, 6 months ago (2014-06-06 23:57:38 UTC) #3

Message was sent while issue was closed.

Change committed as 275620

Expand Messages | Collapse Messages