Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 317163004: Replace the HomeCard by the AppList in Athena (2nd) (Closed)

Created:
6 years, 6 months ago by Jun Mukai
Modified:
6 years, 6 months ago
Reviewers:
benwells, oshima, reed1
CC:
chromium-reviews, Marijn Kruisselbrink
Visibility:
Public.

Description

Replace the HomeCard by the AppList in Athena (2nd) This is a reland of https://codereview.chromium.org/306083005/. That was reverted because it implicitly added a dependency on content from athena_shell. This is identical to the original CL but still safe because the dependency issue has been fixed already. BUG=370204 TBR=oshima@chromium.org, benwells@chromium.org, reed@google.com TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -108 lines) Patch
M athena/athena.gyp View 2 chunks +3 lines, -2 lines 0 comments Download
M athena/home/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A athena/home/app_list_view_delegate.h View 1 chunk +64 lines, -0 lines 0 comments Download
A athena/home/app_list_view_delegate.cc View 1 chunk +235 lines, -0 lines 0 comments Download
D athena/home/home_card_delegate_view.h View 1 chunk +0 lines, -33 lines 0 comments Download
D athena/home/home_card_delegate_view.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M athena/home/home_card_impl.cc View 5 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-05 19:49:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/317163004/1
6 years, 6 months ago (2014-06-05 19:51:54 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 02:53:41 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 06:39:42 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/36329)
6 years, 6 months ago (2014-06-06 06:39:43 UTC) #5
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-06 08:29:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/317163004/1
6 years, 6 months ago (2014-06-06 08:31:02 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 10:22:52 UTC) #8
Message was sent while issue was closed.
Change committed as 275373

Powered by Google App Engine
This is Rietveld 408576698