Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 317153003: Create a rappor.xml file to document rappor metrics (Closed)

Created:
6 years, 6 months ago by Steven Holte
Modified:
6 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, jar+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Create a rappor.xml file to document rappor metrics BUG=381374 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275321

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
A tools/metrics/rappor/rappor.xml View 1 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Steven Holte
6 years, 6 months ago (2014-06-05 21:16:36 UTC) #1
Alexei Svitkine (slow)
LGTM % comment https://codereview.chromium.org/317153003/diff/1/tools/metrics/rappor/rappor.xml File tools/metrics/rappor/rappor.xml (right): https://codereview.chromium.org/317153003/diff/1/tools/metrics/rappor/rappor.xml#newcode8 tools/metrics/rappor/rappor.xml:8: This file is used to generate ...
6 years, 6 months ago (2014-06-05 21:18:59 UTC) #2
Alexei Svitkine (slow)
Please file a crbug for this work.
6 years, 6 months ago (2014-06-05 21:20:49 UTC) #3
Steven Holte
https://codereview.chromium.org/317153003/diff/1/tools/metrics/rappor/rappor.xml File tools/metrics/rappor/rappor.xml (right): https://codereview.chromium.org/317153003/diff/1/tools/metrics/rappor/rappor.xml#newcode8 tools/metrics/rappor/rappor.xml:8: This file is used to generate a comprehensive list ...
6 years, 6 months ago (2014-06-05 21:34:34 UTC) #4
Steven Holte
The CQ bit was checked by holte@chromium.org
6 years, 6 months ago (2014-06-05 21:36:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/holte@chromium.org/317153003/20001
6 years, 6 months ago (2014-06-05 21:40:20 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 02:18:27 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 03:32:53 UTC) #8
Message was sent while issue was closed.
Change committed as 275321

Powered by Google App Engine
This is Rietveld 408576698