Issue 317153002: [DevTools] Move user agent override to responsive design toolbar.

Issue 317153002: [DevTools] Move user agent override to responsive design toolbar. (Closed)

Created:
6 years, 6 months ago by dgozman

Modified:
6 years, 6 months ago

Reviewers:
apavlov, vsevik, aandrey, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[DevTools] Move user agent override to responsive design toolbar. This also made toolbar expandable to accomodate controls for rarely used features. BUG=327641 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175663

Patch Set 1 #

Patch Set 2 : Optimized pngs #

Total comments: 2

Patch Set 3 : rebased #

Patch Set 4 : mac style #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+307 lines, -376 lines)			Patch
M	Source/devtools/front_end/Images/responsiveDesign.png	View	1	Binary file		0 comments	Download
M	Source/devtools/front_end/Images/responsiveDesign_2x.png	View	1	Binary file		0 comments	Download
M	Source/devtools/front_end/Images/src/optimize_png.hashes	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/Images/src/responsiveDesign.svg	View	1	1 chunk	+11 lines, -210 lines	0 comments	Download
M	Source/devtools/front_end/Images/src/svg2png.hashes	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/ResponsiveDesignView.js	View	1 2	11 chunks	+65 lines, -19 lines	0 comments	Download
M	Source/devtools/front_end/common/DOMExtension.js	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/common/Settings.js	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/elements/OverridesView.js	View	1 2	2 chunks	+5 lines, -127 lines	0 comments	Download
M	Source/devtools/front_end/inspector.css	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/main/AdvancedApp.js	View	1 2	1 chunk	+5 lines, -5 lines	0 comments	Download
M	Source/devtools/front_end/overrides.css	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/responsiveDesignView.css	View	1 2 3	7 chunks	+66 lines, -12 lines	0 comments	Download
M	Source/devtools/front_end/sdk/OverridesSupport.js	View	1 2	4 chunks	+130 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

dgozman

Could you please take a look? Screenshot: http://pbrd.co/1kx4SZX.

6 years, 6 months ago (2014-06-05 11:30:37 UTC) #1

aandrey

FYI https://codereview.chromium.org/317153002/diff/20001/Source/devtools/front_end/ResponsiveDesignView.js File Source/devtools/front_end/ResponsiveDesignView.js (right): https://codereview.chromium.org/317153002/diff/20001/Source/devtools/front_end/ResponsiveDesignView.js#newcode505 Source/devtools/front_end/ResponsiveDesignView.js:505: this._toolbarSection.textContent = ""; we can add Element.prototype.appendChildren() in ...

6 years, 6 months ago (2014-06-05 14:44:37 UTC) #4

dgozman

https://codereview.chromium.org/317153002/diff/20001/Source/devtools/front_end/ResponsiveDesignView.js File Source/devtools/front_end/ResponsiveDesignView.js (right): https://codereview.chromium.org/317153002/diff/20001/Source/devtools/front_end/ResponsiveDesignView.js#newcode505 Source/devtools/front_end/ResponsiveDesignView.js:505: this._toolbarSection.textContent = ""; On 2014/06/05 14:44:38, aandrey wrote: > ...

6 years, 6 months ago (2014-06-06 11:31:12 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/317153002/60001

6 years, 6 months ago (2014-06-06 11:31:59 UTC) #7

Message was sent while issue was closed.

Change committed as 175663

Expand Messages | Collapse Messages