Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: Source/core/css/invalidation/StyleInvalidator.cpp

Issue 317133002: Skip traversing wholeSubtree subtrees with clean invalidation bits. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/css/invalidation/targeted-class-whole-subtree-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/invalidation/StyleInvalidator.cpp
diff --git a/Source/core/css/invalidation/StyleInvalidator.cpp b/Source/core/css/invalidation/StyleInvalidator.cpp
index 3874c2b93e68f63610c8ad2889e925bec1a61e84..5f93cc5579f26a863bf30ff386e955a6011986fd 100644
--- a/Source/core/css/invalidation/StyleInvalidator.cpp
+++ b/Source/core/css/invalidation/StyleInvalidator.cpp
@@ -140,7 +140,7 @@ bool StyleInvalidator::invalidate(Element& element)
bool thisElementNeedsStyleRecalc = checkInvalidationSetsAgainstElement(element);
bool someChildrenNeedStyleRecalc = false;
- if (m_recursionData.hasInvalidationSets() || element.childNeedsStyleInvalidation())
+ if ((!m_recursionData.wholeSubtreeInvalid() && m_recursionData.hasInvalidationSets()) || element.childNeedsStyleInvalidation())
esprehn 2014/06/05 09:40:24 I think we should just return false from hasInvali
rune 2014/06/05 09:52:26 Done.
someChildrenNeedStyleRecalc = invalidateChildren(element);
if (thisElementNeedsStyleRecalc) {
« no previous file with comments | « LayoutTests/fast/css/invalidation/targeted-class-whole-subtree-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698