Skip traversing wholeSubtree subtrees with clean invalidation bits.

Skip traversing wholeSubtree subtrees with clean invalidation bits.

During style invalidation we need to continue to traverse a subtree that is
marked with SubtreeStyleChange to clear any remaining invalidation bits.
But, when the childNeedsInvalidation bit is not set, there should be no
bits left to clear in the subtree. Hence, we can skip traversing that
subtree.

R=esprehn@chromium.org,chrishtr@chromium.org
BUG=381062
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175564

[esprehn, 2014-06-05 09:40:24]

https://codereview.chromium.org/317133002/diff/1/Source/core/css/invalidation...
File Source/core/css/invalidation/StyleInvalidator.cpp (right):

https://codereview.chromium.org/317133002/diff/1/Source/core/css/invalidation...
Source/core/css/invalidation/StyleInvalidator.cpp:143: if
((!m_recursionData.wholeSubtreeInvalid() &&
m_recursionData.hasInvalidationSets()) || element.childNeedsStyleInvalidation())
I think we should just return false from hasInvalidationSets() here. There's no
sets to invalidate if the whole subtree is invalid.

[rune, 2014-06-05 09:52:26]

https://codereview.chromium.org/317133002/diff/1/Source/core/css/invalidation...
File Source/core/css/invalidation/StyleInvalidator.cpp (right):

https://codereview.chromium.org/317133002/diff/1/Source/core/css/invalidation...
Source/core/css/invalidation/StyleInvalidator.cpp:143: if
((!m_recursionData.wholeSubtreeInvalid() &&
m_recursionData.hasInvalidationSets()) || element.childNeedsStyleInvalidation())
On 2014/06/05 09:40:24, esprehn wrote:
> I think we should just return false from hasInvalidationSets() here. There's
no
> sets to invalidate if the whole subtree is invalid.

Done.

[esprehn, 2014-06-05 09:53:26]

lgtm

[commit-bot: I haz the power, 2014-06-05 09:54:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rune@opera.com/317133002/20001

[commit-bot: I haz the power, 2014-06-05 11:03:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10768)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-05 11:04:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 11:04:48]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[rune, 2014-06-05 11:34:17]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-06-05 11:35:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rune@opera.com/317133002/20001

[commit-bot: I haz the power, 2014-06-05 12:52:19]

Change committed as 175564