Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 317113002: Use echo handler in send-object-tostring-check (Closed)

Created:
6 years, 6 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 6 months ago
Reviewers:
yhirano
CC:
blink-reviews
Visibility:
Public.

Description

Use echo handler in send-object-tostring-check It doesn't need to get host echoed back. Just use the simple echo handler. Some unnecessary div elements are removed. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175633

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M LayoutTests/http/tests/websocket/send-object-tostring-check.html View 1 1 chunk +10 lines, -9 lines 0 comments Download
M LayoutTests/http/tests/websocket/send-object-tostring-check-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 6 months ago (2014-06-05 07:46:24 UTC) #1
tyoshino (SeeGerritForStatus)
On 2014/06/05 07:46:24, tyoshino wrote: Just uploaded a new patch set. PTAL
6 years, 6 months ago (2014-06-05 07:48:01 UTC) #2
yhirano
lgtm
6 years, 6 months ago (2014-06-06 01:41:50 UTC) #3
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 6 months ago (2014-06-06 01:42:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/317113002/20001
6 years, 6 months ago (2014-06-06 01:42:59 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-06 02:52:46 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 03:56:42 UTC) #7
Message was sent while issue was closed.
Change committed as 175633

Powered by Google App Engine
This is Rietveld 408576698