Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3547)

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.h

Issue 317093002: Show confirmation dialog for unsecure signin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.h
diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.h b/chrome/browser/ui/webui/signin/inline_login_handler_impl.h
index 9273b044723b477da7fb93263f4c689e5d774c8f..43b3387ba708e83eb4684dc4b8bbc5da48b90e4b 100644
--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.h
+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.h
@@ -19,7 +19,8 @@ class GaiaAuthFetcher;
// CrOS migrates to the same webview approach as desktop Chrome, much of the
// code in this class should move to its base class |InlineLoginHandler|.
class InlineLoginHandlerImpl : public InlineLoginHandler,
- public content::WebContentsDelegate {
+ public content::WebContentsDelegate,
+ public content::WebContentsObserver {
public:
InlineLoginHandlerImpl();
virtual ~InlineLoginHandlerImpl();
@@ -46,11 +47,16 @@ class InlineLoginHandlerImpl : public InlineLoginHandler,
virtual bool HandleContextMenu(
const content::ContextMenuParams& params) OVERRIDE;
+ // Overridden from content::WebContentsObserver overrides.
+ virtual void DidCommitProvisionalLoadForFrame(
+ content::RenderFrameHost* render_frame_host,
+ const GURL& url,
+ content::PageTransition transition_type) OVERRIDE;
+
base::WeakPtrFactory<InlineLoginHandlerImpl> weak_factory_;
- std::string email_;
- std::string password_;
- std::string session_index_;
- bool choose_what_to_sync_;
+ // True if the user has navigated to untrusted domains during the signin
+ // process.
+ bool confirm_untrusted_signin_;
DISALLOW_COPY_AND_ASSIGN(InlineLoginHandlerImpl);
};

Powered by Google App Engine
This is Rietveld 408576698