Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 317073007: Oilpan: Prepare to move EventHandler to Oilpan heap. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Oilpan: Prepare to move EventHandler to Oilpan heap. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -18 lines) Patch
M Source/core/frame/LocalFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.h View 5 chunks +16 lines, -16 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tkent
Please review this trivial CL.
6 years, 6 months ago (2014-06-05 02:14:29 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-05 02:17:58 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-05 02:20:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/317073007/1
6 years, 6 months ago (2014-06-05 02:21:03 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-05 03:18:04 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 03:18:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/14161)
6 years, 6 months ago (2014-06-05 03:18:17 UTC) #7
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-05 06:18:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/317073007/1
6 years, 6 months ago (2014-06-05 06:18:59 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 06:19:35 UTC) #10
Message was sent while issue was closed.
Change committed as 175537

Powered by Google App Engine
This is Rietveld 408576698