|
|
Created:
6 years, 6 months ago by Alex Vakulenko (Google) Modified:
6 years, 6 months ago Reviewers:
Elliot Glaysher, M-A Ruel CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Visibility:
Public. |
DescriptionUpdate cpplint.py to r133.
The only difference compared to upstream[1] is the shebang line from
depot_tools.
[1] https://code.google.com/p/google-styleguide/source/browse/trunk/cpplint/cpplint.py?spec=svn131&r=133
BUG=None
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=274946
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #
Created: 6 years, 6 months ago
Messages
Total messages: 15 (0 generated)
I have landed the google3-derived updates for cpplint.py to the official google-styleguide and now I'm porting those to the depot_tools version of cpplint.py.
Elliot owns this file, lgtm if he's fine.
lgtm
The CQ bit was checked by avakulenko@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avakulenko@google.com/317053002/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 317053002-1 failed and returned exit status 1. Running presubmit commit checks ... Checking out rietveld... Running save-description-on-failure.sh Running push-basic.sh Running upstream.sh Running submit-from-new-dir.sh Running abandon.sh Running submodule-merge-test.sh Running upload-local-tracking-branch.sh Running hooks.sh Running post-dcommit-hook-test.sh Running upload-stale.sh Running patch.sh Running basic.sh ** Presubmit ERRORS ** Pylint (96 files) (31.75s) failed ************* Module /b/infra_internal/commit_queue/workdir/tools/depot_tools/gcl.py E1121:1233,10:CMDlint: Too many positional arguments for function call ************* Module /b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py E1121:1438,10:CMDlint: Too many positional arguments for function call Presubmit checks took 124.8s to calculate.
The CQ bit was checked by avakulenko@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avakulenko@google.com/317053002/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 317053002-1 failed and returned exit status 1. Running presubmit commit checks ... Checking out rietveld... Running save-description-on-failure.sh Running push-basic.sh Running upstream.sh Running submit-from-new-dir.sh Running abandon.sh Running submodule-merge-test.sh Running upload-local-tracking-branch.sh Running hooks.sh Running post-dcommit-hook-test.sh Running upload-stale.sh Running patch.sh Running basic.sh ** Presubmit ERRORS ** Pylint (96 files) (26.56s) failed ************* Module /b/infra_internal/commit_queue/workdir/tools/depot_tools/gcl.py E1121:1233,10:CMDlint: Too many positional arguments for function call ************* Module /b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py E1121:1438,10:CMDlint: Too many positional arguments for function call Presubmit checks took 122.1s to calculate.
Fixed the CQ break...
The CQ bit was checked by avakulenko@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avakulenko@google.com/317053002/40001
Message was sent while issue was closed.
Change committed as 274946 |