Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 317053002: Update cpplint.py to r133. (Closed)

Created:
6 years, 6 months ago by Alex Vakulenko (Google)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Update cpplint.py to r133. The only difference compared to upstream[1] is the shebang line from depot_tools. [1] https://code.google.com/p/google-styleguide/source/browse/trunk/cpplint/cpplint.py?spec=svn131&r=133 BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=274946

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1459 lines, -592 lines) Patch
M cpplint.py View 1 87 chunks +1459 lines, -592 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Alex Vakulenko (Google)
I have landed the google3-derived updates for cpplint.py to the official google-styleguide and now I'm ...
6 years, 6 months ago (2014-06-04 19:37:59 UTC) #1
M-A Ruel
Elliot owns this file, lgtm if he's fine.
6 years, 6 months ago (2014-06-04 20:02:33 UTC) #2
Elliot Glaysher
lgtm
6 years, 6 months ago (2014-06-04 20:15:28 UTC) #3
Alex Vakulenko (Google)
The CQ bit was checked by avakulenko@google.com
6 years, 6 months ago (2014-06-04 20:58:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avakulenko@google.com/317053002/1
6 years, 6 months ago (2014-06-04 20:59:01 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 21:01:09 UTC) #6
commit-bot: I haz the power
Presubmit check for 317053002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 6 months ago (2014-06-04 21:01:10 UTC) #7
Alex Vakulenko (Google)
The CQ bit was checked by avakulenko@google.com
6 years, 6 months ago (2014-06-04 21:54:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avakulenko@google.com/317053002/1
6 years, 6 months ago (2014-06-04 21:55:11 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 21:57:17 UTC) #10
commit-bot: I haz the power
Presubmit check for 317053002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 6 months ago (2014-06-04 21:57:17 UTC) #11
Alex Vakulenko (Google)
Fixed the CQ break...
6 years, 6 months ago (2014-06-04 22:48:47 UTC) #12
Alex Vakulenko (Google)
The CQ bit was checked by avakulenko@google.com
6 years, 6 months ago (2014-06-04 22:52:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avakulenko@google.com/317053002/40001
6 years, 6 months ago (2014-06-04 22:53:38 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 22:55:21 UTC) #15
Message was sent while issue was closed.
Change committed as 274946

Powered by Google App Engine
This is Rietveld 408576698