Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1634)

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 317013008: Fix LayerTreeHostTestUndrawnLayersDamageLater flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest.cc
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc
index 870f2df5f89f1a459c9433eb894d1cb52a8eb2d0..9aa0d04b5aea6c285573810648c98cace2fa9220 100644
--- a/cc/trees/layer_tree_host_unittest.cc
+++ b/cc/trees/layer_tree_host_unittest.cc
@@ -574,15 +574,13 @@ class LayerTreeHostTestUndrawnLayersDamageLater : public LayerTreeHostTest {
// and each damage should be the bounding box of it and its child. If this
// was working improperly, the damage might not include its childs bounding
// box.
- // TODO(enne): This compositor thread function is asking for the
- // frame number from the layer tree host on the main thread. :(
- switch (layer_tree_host()->source_frame_number()) {
- case 1:
+ switch (host_impl->active_tree()->source_frame_number()) {
+ case 0:
EXPECT_RECT_EQ(gfx::Rect(root_layer_->bounds()), root_damage_rect);
break;
+ case 1:
case 2:
case 3:
- case 4:
EXPECT_RECT_EQ(gfx::Rect(child_layer_->bounds()), root_damage_rect);
break;
default:
@@ -623,8 +621,7 @@ class LayerTreeHostTestUndrawnLayersDamageLater : public LayerTreeHostTest {
scoped_refptr<FakeContentLayer> child_layer_;
};
-// TODO(enne): http://crbug.com/380895
-// SINGLE_AND_MULTI_THREAD_TEST_F(LayerTreeHostTestUndrawnLayersDamageLater);
+SINGLE_AND_MULTI_THREAD_TEST_F(LayerTreeHostTestUndrawnLayersDamageLater);
// Tests that if a layer is not drawn because of some reason in the parent,
// causing its content bounds to not be computed, then when it is later drawn,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698