Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 317013005: Make CompositingReasonFinder::requiresCompositingForAnimation take RenderStyle* (Closed)

Created:
6 years, 6 months ago by ajuma
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Make CompositingReasonFinder::requiresCompositingForAnimation take RenderStyle* This makes CompositingReasonFinder::requiresCompositingForAnimation take a RenderStyle* rather than a RenderObject*. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175692

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M Source/core/rendering/compositing/CompositingReasonFinder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ajuma
This addresses abarth's comment from https://codereview.chromium.org/298723011/#msg14
6 years, 6 months ago (2014-06-06 17:50:37 UTC) #1
abarth-chromium
LGTM https://codereview.chromium.org/317013005/diff/1/Source/core/rendering/compositing/CompositingReasonFinder.cpp File Source/core/rendering/compositing/CompositingReasonFinder.cpp (right): https://codereview.chromium.org/317013005/diff/1/Source/core/rendering/compositing/CompositingReasonFinder.cpp#newcode113 Source/core/rendering/compositing/CompositingReasonFinder.cpp:113: if (requiresCompositingForAnimation(renderer->style())) There's already a |style| local variable ...
6 years, 6 months ago (2014-06-06 18:10:53 UTC) #2
ajuma
https://codereview.chromium.org/317013005/diff/1/Source/core/rendering/compositing/CompositingReasonFinder.cpp File Source/core/rendering/compositing/CompositingReasonFinder.cpp (right): https://codereview.chromium.org/317013005/diff/1/Source/core/rendering/compositing/CompositingReasonFinder.cpp#newcode113 Source/core/rendering/compositing/CompositingReasonFinder.cpp:113: if (requiresCompositingForAnimation(renderer->style())) On 2014/06/06 18:10:53, abarth wrote: > There's ...
6 years, 6 months ago (2014-06-06 18:13:31 UTC) #3
ajuma
The CQ bit was checked by ajuma@chromium.org
6 years, 6 months ago (2014-06-06 18:13:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/317013005/20001
6 years, 6 months ago (2014-06-06 18:14:14 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-06 19:20:24 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 19:23:05 UTC) #7
Message was sent while issue was closed.
Change committed as 175692

Powered by Google App Engine
This is Rietveld 408576698