Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 317003004: Revert the revert of 275818: "dcommit binaries for test for code review 310483003" (Closed)

Created:
6 years, 6 months ago by Andrew Hayden (chromium.org)
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert the revert of 275818: "dcommit binaries for test for code review 310483003" Reverts: https://codereview.chromium.org/323923002/ Which reverted: https://codereview.chromium.org/310483003/ The revert was necessary because the .so files in this patch apparently need to have their executable bits set, even though they are just test data that isn't actually executable. For posterity, the presubmit scripts were run with "-v" locally, but did not show the error that the bots eventually produced. BUG= R=simonb@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A tools/relocation_packer/test_data/elf_file_unittest_relocs.so View Binary file 0 comments Download
A tools/relocation_packer/test_data/elf_file_unittest_relocs_packed.so View Binary file 0 comments Download

Messages

Total messages: 3 (0 generated)
Andrew Hayden (chromium.org)
Sorry about that. This time, presubmit scripts are apparently happy (last time, they were complaining ...
6 years, 6 months ago (2014-06-09 17:30:24 UTC) #1
simonb1
lgtm
6 years, 6 months ago (2014-06-09 17:32:35 UTC) #2
Andrew Hayden (chromium.org)
6 years, 6 months ago (2014-06-09 17:33:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r275833 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698