Issue 316983006: SPDY4 shouldn't emit RST_STREAM payloads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 316983006: SPDY4 shouldn't emit RST_STREAM payloads. (Closed)

Created:
6 years, 6 months ago by Johnny

Modified:
6 years, 6 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

SPDY4 shouldn't emit RST_STREAM payloads. SpdyFramer will accept them, and frame them if present. We may want to leave this for later SPDY versions, but certainly don't emit them in SPDY4. BUG=345769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275512

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	net/spdy/buffered_spdy_framer.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	net/spdy/spdy_test_util_common.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/316983006/1

6 years, 6 months ago (2014-06-06 19:10:45 UTC) #4

Message was sent while issue was closed.

Change committed as 275512

Expand Messages | Collapse Messages