Issue 316983003: Simplify createShapeForImage handling of image pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 316983003: Simplify createShapeForImage handling of image pointers (Closed)

Created:
6 years, 6 months ago by Bem Jones-Bey (adobe)

Modified:
6 years, 6 months ago

Reviewers:
leviw_travelin_and_unemployed, pdr.

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Simplify createShapeForImage handling of image pointers StyleImage::image can be used to get a cached image just like it can be used to get a generated image. So we can just have one RefPtr and remove the raw pointer, simplifiying the code immensely. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175516