Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Issue 316963004: Tighten match for the chromium 'src' repo. (Closed)

Created:
6 years, 6 months ago by Michael Moss
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cmp-cc_chromium.org
Visibility:
Public.

Description

Tighten match for the chromium 'src' repo. This was accidentally matching the '/trunk/src' in: /trunk/src/chrome/test/data/reliability@237714 and causing that entry to map to chromium/src.git R=ivanpe@google.com, szager@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274952

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M buildspec_to_git.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Moss
6 years, 6 months ago (2014-06-04 22:33:20 UTC) #1
szager1
https://codereview.chromium.org/316963004/diff/1/buildspec_to_git.py File buildspec_to_git.py (right): https://codereview.chromium.org/316963004/diff/1/buildspec_to_git.py#newcode131 buildspec_to_git.py:131: match = re.match('/(branches/(?P<branch>[^/]+)|trunk)/src^', svn_url) Should that be '$'?
6 years, 6 months ago (2014-06-04 22:42:50 UTC) #2
Michael Moss
https://codereview.chromium.org/316963004/diff/1/buildspec_to_git.py File buildspec_to_git.py (right): https://codereview.chromium.org/316963004/diff/1/buildspec_to_git.py#newcode131 buildspec_to_git.py:131: match = re.match('/(branches/(?P<branch>[^/]+)|trunk)/src^', svn_url) On 2014/06/04 22:42:51, szager1 wrote: ...
6 years, 6 months ago (2014-06-04 22:44:37 UTC) #3
ivanpe
On 2014/06/04 22:44:37, Michael Moss wrote: > https://codereview.chromium.org/316963004/diff/1/buildspec_to_git.py > File buildspec_to_git.py (right): > > https://codereview.chromium.org/316963004/diff/1/buildspec_to_git.py#newcode131 ...
6 years, 6 months ago (2014-06-04 23:30:01 UTC) #4
Michael Moss
6 years, 6 months ago (2014-06-04 23:39:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r274952 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698