build/android/findbugs_filter/findbugs_exclude.xml - Issue 316963003: Keep a static reference to Java GCMDriver instance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/findbugs_filter/findbugs_exclude.xml

Issue 316963003: Keep a static reference to Java GCMDriver instance (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix FindBugs Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/findbugs_filter/findbugs_exclude.xml

diff --git a/build/android/findbugs_filter/findbugs_exclude.xml b/build/android/findbugs_filter/findbugs_exclude.xml

index 01d8df9dad3dd96bd8f62aa14c68b3a64076805d..bf0e51f6945d6b70797f43ee79053dbfeb86383f 100644

--- a/build/android/findbugs_filter/findbugs_exclude.xml

+++ b/build/android/findbugs_filter/findbugs_exclude.xml

@@ -89,4 +89,13 @@ In particular, ~ at the start of a string means it's a regex.

</Match>

+ <!--

+ Ignore write to static field in GCMDriver, as it's the cleanest way to mark

+ the singleton as null when the native counterpart is destroyed.

+ -->

+ <Match>

+ <Class name="~org\.chromium\.components\.gcm_driver\..*\.GCMDriver" />

+ <Method name="destroy" />

+ <Bug code="ST" />

+ </Match>

</FindBugsFilter>

« no previous file with comments | « no previous file | components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java » ('j') | no next file with comments »